Hi,
I'm Marc from Berlin, Germany, and I would like to contribute to this project.
I followed the short instructions on the darktable development website and
made a first patch:
The function dt_supported_image in darktable.c contains a TODO comment which
is apparently outdated. Also, I added a small optimization to the function.
Regards,
Marc
--
http://www.marcaltmann.com/
>From 825ffd2266f2bda272fac050e8a39f035323bcce Mon Sep 17 00:00:00 2001
From: Marc Altmann <[email protected]>
Date: Thu, 15 Nov 2012 22:53:42 +0100
Subject: [PATCH] removed comment and did one optimization in
dt_supported_image
---
src/common/darktable.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/darktable.c b/src/common/darktable.c
index a17c659..54a60a3 100644
--- a/src/common/darktable.c
+++ b/src/common/darktable.c
@@ -238,15 +238,15 @@ darktable will now close down.\n\n%s"),message);
}
#endif
-/* TODO: make this case insensitive */
gboolean dt_supported_image(const gchar *filename)
{
gboolean supported = FALSE;
char **extensions = g_strsplit(dt_supported_extensions, ",", 100);
char *ext = g_strrstr(filename,".");
if(!ext) return FALSE;
+ ext++;
for(char **i=extensions; *i!=NULL; i++)
- if(!g_ascii_strncasecmp(ext+1, *i,strlen(*i)))
+ if(!g_ascii_strncasecmp(ext, *i,strlen(*i)))
{
supported = TRUE;
break;
--
1.7.8.6
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel