awesome :) On Wed, Nov 28, 2012 at 10:59 AM, Henrik Andersson <[email protected]> wrote: > > > > ---------- Forwarded message ---------- > From: Henrik Andersson <[email protected]> > Date: 2012/11/27 > Subject: Re: [darktable-devel] Thumbs not showing for NEF in the import > dialog > To: Mattias Eriksson <[email protected]> > > > Pushed! > > > 2012/11/27 Mattias Eriksson <[email protected]> >> >> Here is my attempt at a git formated patch >> >> //Snaggen >> >> >> >> 2012/11/27 Henrik Andersson <[email protected]> >>> >>> Nice, clean and simple.. >>> >>> could you create a git formatted patch so you get the commit ownership >>> >>> /H >>> >>> >>> 2012/11/27 Mattias Eriksson <[email protected]> >>>> >>>> Here is a working patch to get thumbnails for raw files on sdcards, >>>> based on the algorithm I previously described. I have attached the diff >>>> and >>>> a screenshot of it in action. >>>> >>>> //Snaggen >>>> >>>> >>>> >>>> >>>> >>>> 2012/11/26 Mattias Eriksson <[email protected]> >>>>> >>>>> Ok, after looking into the code a little deeper, I understand what you >>>>> mean that it is gphoto centric... the "do stuff with the extracted raw" in >>>>> my suggestion, would mean to fake some gphoto structs... which might also >>>>> be >>>>> a lot of work and not really a recommended solution :) >>>>> >>>>> >>>>> >>>>> 2012/11/26 Mattias Eriksson <[email protected]> >>>>>> >>>>>> Well, I don't know the code and the design so I can only assume that >>>>>> your suggestion to use a different import for storage devices, is the >>>>>> best >>>>>> long term solution. But it sounds like quite a lot of work! My suggestion >>>>>> was meant as a short term "quick and dirty" fix for only the lack of >>>>>> thumbnails for raw files on storage devices. >>>>>> >>>>>> //Snaggen >>>>>> >>>>>> >>>>>> >>>>>> 2012/11/26 Henrik Andersson <[email protected]> >>>>>>> >>>>>>> My suggestion to all this is to try prevent user for using anything >>>>>>> else then PTP >>>>>>> and implement a file based import that copy files to storage, that >>>>>>> would give one >>>>>>> possibility to import from any filesystem into darktable. This can >>>>>>> also be replacing >>>>>>> the actual PTP camera import code due to its unreliable >>>>>>> functionality >>>>>>> where gphoto2 >>>>>>> need to have PTP support for the specific camera. >>>>>>> >>>>>>> /Henrik >>>>>>> >>>>>>> >>>>>>> 2012/11/26 Mattias Eriksson <[email protected]>: >>>>>>> > I realize the if statement is wrong >>>>>>> > >>>>>>> > My new else was suppsed to match the >>>>>>> > if( cfi.file.size > 0 && cfi.file.size < 512000 ) >>>>>>> > >>>>>>> > >>>>>>> > //Snaggen >>>>>> >>>>>> >>>>> >>>> >>> >> > > > > > ------------------------------------------------------------------------------ > Keep yourself connected to Go Parallel: > DESIGN Expert tips on starting your parallel project right. > http://goparallel.sourceforge.net > _______________________________________________ > darktable-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/darktable-devel >
------------------------------------------------------------------------------ Keep yourself connected to Go Parallel: DESIGN Expert tips on starting your parallel project right. http://goparallel.sourceforge.net _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
