2012/12/9 johannes hanika <[email protected]>
> On Mon, Dec 10, 2012 at 10:48 AM, AlicVB <[email protected]> wrote:
> > Hi all,
> >
> > Just a thought : I think module should expose function if they do image
> > distortion. Now we have just the spot iop which suffer of problem, but
> > the mask tool will have this problem too :
> > example :
> > - take an image and apply some rotation.
> > - now when you want to define some spots, the image is unrotated (the
> > flag IOP_FLAGS_DISTORT )
> > this not really elegant imho. Here, it's not too problematic, but
> > imagine that the image become unrotated each time you want to modify
> > (even see) a mask...
> >
> > I think we can add 2 functions to the iop API : transform and
> backtransform
> > the first one for showing masks, spots, ... on a distorted image. The
> > second one to store coords when you define the masks, spots...
> >
> > this functions shouldn't be too difficult to implement (except maybe for
> > lensfun ?)
>
> lensfun has a reverse mode.
>
> That's a good point !
> > I see some problem with this approach, thought:
> > 1- with spots for example (but it's the same for all kind of form) :
> > We store just the center coords and the radius. So if you have applied a
> > severe keystone correction for ex., you may see an ellipse and not a
> > circle, when you add a new spot.
>
> yep, so you'll need to compute it on a pixel buffer and then map that
> through the distortions..
>
> > 2- I don't know if processing this function for all the distort iop will
> > not be too long to keep responding gui
>
> yeah, that's a good point. you can probably process some downresed
> version, but i'm not sure that'll yield acceptable precision.
>
> I think this may need tests... after all we will process not too many
datas compare to full image process !
> > 3- Can wee add such functions to the module api ?
> >
> > What do you think ?
>
> definitely worth a discussion :) we don't have all that many
> distortion modules, i guess what you're proposing is possible. maybe
> some tedious work (i hate transform matrices!), but the result will
> definitely be a lot more elegant than what we have now.
>
> In fact, all is already in place afaik : borders : trivial I think;
clipping : already in place; there is just lensfun : I don't know anything
about the api...
> -jo
>
Aldric
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
