On Mon, Jan 7, 2013 at 12:59 AM, Richard Tollerton
<[email protected]> wrote:
> The wb_extract.pl results used for this patch are at the bottom of this
> message. I wound up submitting a patch becasue that seemed to be the
> best way to validate my submission. I ran into the following issues when
> using wb_extract.pl:
>
> - Manufacturer field contains camera model
> - Camera model field is empty
> - "Shade" setting was incorrectly detected as "Auto"
> - Fine-tuning field seems to be incorrectly interpreted: if the camera
>   preset has a number in its icon, that number is the value of the
>   fine-tuning field, and 0 otherwise. For instance, the icon for "Warm
>   White Fluorescent" has a "-1" at the bottom.

Yep, the script has been unmaintained for some time now, as I've
mentioned in our camera support article.

> I fixed these issues in the submitted patch, and everything seems to
> work ok.

Yep, your original submission looks great! Thanks!

I'll be committing it any minute now. And I'll cherry-pick it for 1.1.2.

Regards,
Pascal de Bruijn

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to