after this (i just took some time bisecting this..) my center view sometimes refuses to update now.
no idea why pthread_mutex_trylock is different to g_mutex_trylock, but i'm assuming somehow this trying fails a lot more often than before. i can reliable trigger it by clicking two entries in the recently used collections module one after the other. the center view will not be updated until i move the mouse. same for when i exit dr mode. i've looked at the code and am unclear what it does. why does it even have this mutex here? shouldn't one gdk lock be enough (which is acquired before anyways)? instead there is a dedicated mutex which the gui thread also has to race for, plus some locking done on some count that i don't understand what it does. in the end, it all calls a signal resulting in a function call in gtk.c:1512 _ui_widget_redraw_callback(.) which in turn acquires the gdk lock again... alltogether this seems a ridiculously involved process to make the gui thread redraw gui widgets.. but looking at it naively, as the internal signal raise function locks the gdk lock, too, and the signal handler double checks the gdk lock.. wouldn't it be enough if dt_control_queue_draw() would just raise that signal? am i missing anything? is that trylock a safeguard against 1000s of redraws? if so, i've implemented a different (simpler) floodstop mechanism and removed a couple of mutices. let me know if there's problems with it (a0c95ad). j. On Fri, Feb 1, 2013 at 9:37 AM, Ulrich Pegelow <ulrich.pege...@tongareva.de> wrote: > Am 31.01.2013 21:01, schrieb Henrik Andersson: >> wohaa, glib did mess that up, im all good with Ulrich patch ! >> >> Revert mine and apply Ulrich's... >> > > OK, done. > > Ulrich > > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > _______________________________________________ > darktable-devel mailing list > darktable-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/darktable-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
