Hi,
some month ago I opened a bug report in lensfun project because one of 
my lens (Tamron 17-50 f2,8 on Pentax K-7) is not recognized by darktable:
http://developer.berlios.de/bugs/?func=detailbug&bug_id=18777&group_id=9034

The iop lens shows the correct camera and lens, but when I enable the 
module it doesn't apply corrections.

It works only if I choose the lens from combo box.

Lensfun developer (da_seeb) now closed my report responding :"Closed, as 
problem is in darktables handling of the database search"

I debugged a bit lens iop and I resolved using fuzzy search method here:

lens.c@719

change

const lfLens **lens = lf_db_find_lenses_hd(dt_iop_lensfun_db, camera, 
NULL, p->lens, 0);

to

const lfLens **lens = lf_db_find_lenses_hd(dt_iop_lensfun_db, camera, 
NULL, p->lens, LF_SEARCH_LOOSE);


Now it works perfectly.
Because I read other lensfun issue in redmine, may be this patch could 
resolve other cases.

The patch is really trivial, so I thinked to don't create a new branch 
or a new pullrequest in github.
I hope it will accepted in master, because is the only way to work with 
iop lens with my Tamron (instead of manual apply a lens correction style).

Note:
in lens.c there are other lf_db_find_lenses_hd() calls, but I think are 
not relevant

Ivan


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to