Hi all, I finally let the mask in paused for 1 or 2 days and work on correcting bug in C&R. I've created a new branch on main repo for that : CR_fixes Currently here's what has been done : 1- save changes done with cropping area even if the pipe is still working (bug #9245) 2- save ratio in image params (should close lot of bugs/feature request like #9151 or #9143 and replace somehow PR #159) 3- avoid cropping area to "jump" when C&R module get focus 4- exported image now respect exactly the ratio (partially fix #9148) 5- different little other fixes
The main "tricky" point is 4 : this indeed correct a "bug", but the weird effect is that it will change the exported size of all already processing pictures. The change is not really big (max 6 pixels) but... And I don't think it's possible to handle that in legacy_params, because we would need to access the whole pipe, or at least all other distort modules to do that (the size change is dependent of the size of the image just before C&R is applied, so after all previous iop have been applied) If some of you have other bugs to fix - in C&r, I mean ;) - please try the branch to see if it's still present and report it. If you are lucky, I'll be able to correct it ! Oh, and as usual : backup _everything_ before testing. I've upgraded C&R params. The upgrade should be handle properly, but not the downgrade ;) Thanks for your comments and tests. Aldric ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
