then let's remove this part of the functionality for now and let's not
alter legacy_params(). we're trying to get a stable release out soon...
j.
On Mon, Apr 1, 2013 at 11:55 AM, Dennis Gnad <[email protected]> wrote:
> Ok, I am sorry, I see the problem, but can't offer a solution that
> doesn't reduce functionality again, I don't know if this is an error
> somewhere else in darktable or by design:
>
> The issue is that "legacy_params" gets a dt_iop_module_t* self pointer
> but can not (or not always, I thought I had tested this....) access
> self->dev - however it needs access to
> self->dev->image_storage.exif_iso. I thought I had tested this before,
> at least in GUI mode.
>
> So now one of the main devs need to help me how to get access to that in
> another way, or fix this if it is an error somewhere else in dt?
>
> Otherwise I can't offer a solution that is still acceptable. I could
> however prepare a PR that still uses the old module version and does not
> really convert parameters nicely (all set to manually selected then).
> Then if we figure out how to do this nicely with legacy_params, we could
> add that and increase module version again ....
>
> But before doing that, maybe someone knows a quick solution to
> inaccessible self->dev (in background threads??) here?
>
> Thanks and best regards
>
> -Dennis
>
> On 31.03.2013 22:48, Pascal Obry wrote:
> >
> > This is the culprit: 0a78638e
> >
> > The problem is that in legacy_params() we call:
> >
> >> dt_noiseprofile_t interpolated =
> dt_iop_denoiseprofile_get_auto_profile(self);
> >
> > which in turns use self->dev->image_storage, but image_storage is not
> > initialized at the time legacy_params() is called. This crash dt.
> >
> > Dennis, can you have a look?
> >
> > Thanks.
> >
> > Pascal.
> >
>
>
>
> ------------------------------------------------------------------------------
> Own the Future-Intel(R) Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest. Compete
> for recognition, cash, and the chance to get your game on Steam.
> $5K grand prize plus 10 genre and skill prizes. Submit your demo
> by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
> _______________________________________________
> darktable-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
