Hi, the recent addition of masks is a major step forward for darktable. It gives huge freedom to image processing that was long awaited for. Cudos to Aldric!
I like how it works even if the feature is still in development. There is one GUI issue where I'd like to give some comments. Currently the per-module masks' GUI is located at the end of the module parameters just before the blend mode is selected. IMHO this is a bit unlogical as currently the masks act just as blend masks even if blending is still off. If conditional blending is activated in addition the conditional parameters together with the blend mask define the area of blending. So from a logical point of view masks and conditional blending act in a similar fashion and their GUIs should be close to each other - but they are not. My idea would be the following order: * first we have the normal module parameters * second there is the blend mode selector (default off) * third there is the combobox selecting the way of blending: "uniformily", "mask", "conditional", "mask & conditional" Depending on the value either the GUI for masks or the one for conditional blending or both would be shown. If "uniformily" is selected the GUIs are hidden. This way we would keep the overall GUI a bit leaner and have a more logical setup of GUI elements. Ulrich ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
