Yes, it would be better. and this is what i'm trying to do.
It's just that i'm unable to split my branch into small commits and send it as 
one PR because of several reasons:
1. branch [1] status: port to gtk3 completed, but gui is not YET displayed 
correctly
2. the diff is too big
3. too big amout of merge rejects if this thing would be merged in one piece

So for now i'm doing small PR's that make dt compile with the more strict rules 
already present in gtk2 which are required for a gtk3 port.
https://developer.gnome.org/gtk3/3.9/gtk-migrating-2-to-3.html

And sometime later (1.3.0, 1.4.0 perhaps) actual switch to GTK+3 will happen.

27 of June 2013, 17:14:12 from jeremy rosen <[email protected]>


Wouldn't it be better to have one pr of small organized commits? It would allow 
us to see the big picture better...
Le 27 juin 2013 14:18, "Lebedev Roman" <[email protected][1]> a écrit :


Hello list!
I would like to start a discussion about porting darktable to gtk3.
 
Current port status(using my branch gtk3-porting[1]): most of the work is 
already done. DT now compiles with gtk3, but is not actual working GTK+3 gui :) 
But my branch is just a lot of huge unstructured commits.
 
I would like to split my branch into BIG amount of simple, self-sufficient 
commits, and send each one as PR.
For now, there won't be any commits that would actually port DT from gtk2 to 
gtk3, but they will just prepare codebase for it. 
 
What do you think?
 
 
I'm already prepared first branch-PR candidate: [2]
If it would be decided that this idea is ok, i'll send a PR.
 
 
[1] https://github.com/LebedevRI/darktable/tree/gtk3-porting[2] 
[2] https://github.com/LebedevRI/darktable/tree/gtk3-00-use-_key_-infix[3]

http://p.sf.net/sfu/windows-dev2dev[4]
[email protected][5]
https://lists.sourceforge.net/lists/listinfo/darktable-devel[6]




--------
[1] mailto:[email protected]
[2] https://github.com/LebedevRI/darktable/tree/gtk3-porting
[3] https://github.com/LebedevRI/darktable/tree/gtk3-00-use-_key_-infix
[4] http://p.sf.net/sfu/windows-dev2dev
[5] mailto:[email protected]
[6] https://lists.sourceforge.net/lists/listinfo/darktable-devel
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to