sorry for the delay, looks good to me, and works as advertised in a quick
test. thanks for working this out!
pushed to master,
-jo
On Tue, Jul 2, 2013 at 1:20 AM, Yari Adán Petralanda <[email protected]>wrote:
> Hi!
>
> Sorry for the late response. I reworked the patch to address your comments:
>
> - I removed IS_BAUHAUS_SLIDER and replaced it with the already existing
> DT_IS_BAUHAUS_WIDGET. I had to add a forward declaration for
> DT_BAUHAUS_WIDGET_TYPE, as it was missing from the calling module (I know
> zero about glib, so there is probably a better way). Also there seemed to
> be a typo in the DT_BAUHAUS_WIDGET_TYPE definition.
>
> - dt_bauhaus_slider_show_popup was removed and replaced by
> dt_bauhaus_show_popup, but I had to make it non-static.
>
> Attached is the new version of the patch. Thanks for the comments!
>
>
> On 24 June 2013 13:05, johannes hanika <[email protected]> wrote:
>
>> hey,
>>
>> thanks for that, looks almost good. a few remarks:
>>
>> - there is DT_IS_BAUHAUS_WIDGET() already, why define IS_BAUHAUS_SLIDER ?
>> also the latter macro doesn't actually check for slider, but for
>> GTK_DRAWING_AREA. you probably want to assert (w->type ==
>> DT_BAUHAUS_SLIDER) either way.
>>
>> - why redefine dt_bauhaus_show_popup as dt_bauhaus_slider_show_popup ?
>>
>> cheers,
>> jo
>>
>>
>>
>> On Sat, Jun 22, 2013 at 10:52 PM, Yari Adán Petralanda <
>> [email protected]> wrote:
>>
>>> Hi all,
>>>
>>> I've just subscribed to the list to contribute a small patch, trying to
>>> connect the bauhaus sliders to key accelerators, as I'm a few weeks late in
>>> my backlog of photo processing since I miss a lot this feature :)
>>>
>>> Hope it is useful.
>>>
>>> Thanks a lot for such a great program!
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>> http://p.sf.net/sfu/windows-dev2dev
>>> _______________________________________________
>>> darktable-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>>>
>>>
>>
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
