On 6/08/13 05:00 PM, Pascal Obry wrote:
> Le 06/08/2013 00:27, James C. McPherson a écrit :
>> what is the root cause of the problem, and which did you
>> change to fix it?
>
> I think my message was clear that I don't know the root cause and that I
> have installed a *defensive* check. What I have seen is a null accel
> struct being accessed. I don't know how such null pointer got into the
> accel list. Maybe someone knowing well this part will be able to fix the
> real issue.
You have just demonstrated that you know enough of the root
cause to provide a fix. Let me suggest a way of expressing
the root cause:
dt_accel_disconnect_list() failed to check list element
validity, and blindly attempted to use null pointers.
The function appears to have ignored the possibility that
the list might ever end. This is a basic programming error
which a static analysis tool will catch, and which a visual
code review should have caught.
Thankyou for fixing it. I'd be grateful if you'd use a more
descriptive comment when you commit.
Thankyou,
James C. McPherson
--
Solaris kernel software engineer, system admin and troubleshooter
http://www.jmcpdotcom.com/blog
Find me on LinkedIn @ http://www.linkedin.com/in/jamescmcpherson
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
