On Wed, Aug 14, 2013 at 5:54 PM, Pascal Obry <pas...@obry.net> wrote:

> Le 14/08/2013 17:51, johannes hanika a écrit :
> >
> >
> >
> > On Wed, Aug 14, 2013 at 5:50 PM, Pascal Obry <pas...@obry.net
> > <mailto:pas...@obry.net>> wrote:
> >
> >
> >     Hi Johannes,
> >
> >     > for everybody's continued basecurve calibration pleasure i've
> pushed a
> >     > small c program to git master:
> >     >
> >     >
> https://github.com/darktable-org/darktable/tree/master/tools/basecurve
> >
> >     Great!
> >
> >     > which you can use to extract a basecurve from a raw + jpg pair. it
> >     takes
> >     > a lot less memory than the python script and will create an
> optimized
> >     > fit to only 8 control points (you can increase it from the cmdline
> if
> >     > necessary). it'll give you a line of code to insert into
> >     iop/basecurve.c
> >     > to get a new preset (after a recompile).
> >
> >     Hum, lot of things are output on my side. I found the necessary line
> for
> >     iop/basecurve.c in the middle of a huge float number output :) Maybe
> >     some debug data still output?
> >
> >
> > right, forgot that detail. you have to call it like
> >
> > make && ./basecurve inputraw.ppm inputjpg.ppm  > basecurve.dat 2> fit.dat
> >
> > i should really create those files directly.
>
> Hum... In fit.dat I have:
>
> # err 114236096512.000000 improved 4 times
> # copy paste into iop/basecurve.c:
> # { "new measured basecurve", "", "", 0, 51200,
> {{{{0.000
> 000, 0.003646}, {0.002878, 0.001839}, {0.025967, 0.034900}, {0.065501,
> 0.167940}
> , {0.203832, 0.503986}, {0.476704, 0.863786}, {0.740543, 0.998729},
> {1.000000, 0
> .000000}}}, {8}, {m}}, 0},
> 0.000000 0.003647
> 0.000015 0.003632
> 0.000031 0.003632
> 0.000046 0.003616
> 0.000061 0.003601
> 0.000076 0.003601
> 0.000092 0.003586
> ...
> <followed by 65500 lines with 2 floats>
>
> Maybe something wrong with my input files?
>

looks perfectly fine. i just pushed the fix for the stdout/stderr
redirection, you can now do:

make && ./basecurve img_raw.ppm img_jpg.ppm
gnuplot plot
evince basecurve.pdf

fit.dat will contain the monotone hermite spline fitted to the green
channel of your measured basecurve as dumped in basecurve.dat. only the one
line in the comment (line 3 in fit.dat) is meant for iop/basecurve.c to try
it from within darktable.

-jo



>
> --
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://v2p.fr.eu.org
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to