Hi Pascal, Le 23/10/2013 09:28, Pascal Obry a écrit : > Aldric, > > Seems like there is an issue with the way the multi_priority is set. > > /.../ > > Then add a new instance of exposure and back to lighttable, then: > > sqlite> select num,operation,multi_priority,multi_name from history > where imgid=816; > 0|exposure|1| > 1|exposure|0|1 > > => this is wrong! The new exposure is marked with multi_version=0 and > multi_name=1??? And the previous one got a multi_priority of 1!!! Yes, I know that, and I would say that this is normal and expected. - First, multi_name is just a convenient way to differentiate the instance, no internal should rely on that (in the future, we can even imagine that the user can change it to whatever he want) - Second point is that as instances can be moved, that means that multi_priority of an history item can change, like other params.
Now in our case, let me explain the apparently incoherent MI values : - when a user create a new instance, we have to set a new name to it, without changing other names (here new instance name = "1") - when a user add a new instance, he want to add a new effect on the top of the actuals. That means that the multi_priority should be inferior to the actual one. As we start the number from 0, that means that we have to increment the priority of the actual instance, and to set the priority of the new instance to 0. So we end up with "exposure 1" -> priority=0 and "exposure" -> priority=1 Not sure to be really clear... I hope you understand what I mean here ! Thanks Aldric > No style involved. I found this issue when looking at the style issue > you reported. > > This needs fixed before I dig further into the style issue. > > Can you have a look? > > Pascal. > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
