On Mon, Oct 28, 2013 at 5:05 PM, Dennis Gnad <den...@xorn.org> wrote:
> Hi,
>
> On 27.10.2013 03:13, Bruce Albert wrote:
> > The defringe module works well if I run darktable with opencl disabled.
>
> this shouldn't make a difference, as I am not using opencl at all, and
> defringe executes the same code no matter if opencl or no opencl. So
> maybe it just exposes some issues elsewhere, or outputs some "wrong"
> colors (more below).
>
> > If I run with opencl enabled and apply the defringe module, I get a
> garbage image if the "sharpen",
> > "shadows and highlights", or "crop and rotate" modules are also active.
> Turning off these modules
> > restores the image to normal. I have not made an exhaustive test as to
> whether this problem
> > exists for other modules; I think that white balance, exposure and
> highlight-reconstruction were OK.
>
> I would be very happy if you can test this with other modules and
> different settings inside the modules, I remember a recent problem with
> some nvidia drivers, so maybe you just see them because of certain color
> values out of the defringe module.
>
> But I could of course really have some issue with accidentally putting
> out some values that are out of the correct ranges for Lab of L[0,100],
> a[-128,+128] and b[-128,+128] - I will check this as soon as I have time
> (but I probably need some days or more...)
>
as long as you're not outputting inf, nan or the likes please leave the
values in. we're not gamut clamping or clipping hdr values until the very
end.
-jo
>
> Best regards,
> Dennis
>
> > Sample images are at:
> http://rapidshare.com/share/83863DFCF04B1727C8F6D755F84BA16E
> >
> > System is kubuntu-13.10, 64-bit, with the nvidia 319.60 driver from the
> ubuntu repositories.
> >
> > This does seem to be more of an opencl problem. I ran with "darktable -d
> opencl", and did not get any
> > unusual message when the image went bad. Here is the output:
> >
> > Image without defringe:
> >
> > [default_process_tiling_cl_ptp] use tiling on module 'temperature' for
> image with full size 4585 x 3472
> > [default_process_tiling_cl_ptp] (2 x 1) tiles with max dimensions 4096 x
> 3472 and overlap 0
> > [default_process_tiling_cl_ptp] tile (0, 0) with 4096 x 3472 at origin
> [0, 0]
> > [default_process_tiling_cl_ptp] tile (1, 0) with 489 x 3472 at origin
> [4096, 0]
> > [default_process_tiling_cl_ptp] use tiling on module 'highlights' for
> image with full size 4585 x 3472
> > [default_process_tiling_cl_ptp] (2 x 1) tiles with max dimensions 4096 x
> 3472 and overlap 0
> > [default_process_tiling_cl_ptp] tile (0, 0) with 4096 x 3472 at origin
> [0, 0]
> > [default_process_tiling_cl_ptp] tile (1, 0) with 489 x 3472 at origin
> [4096, 0]
> > [default_process_tiling_cl_roi] use tiling on module 'demosaic' for
> image with full input size 4585 x 3472
> > [default_process_tiling_cl_roi] (2 x 1) tiles with max input dimensions
> 4096 x 3472
> > [default_process_tiling_cl_roi] tile (0, 0) with 2309 x 3472 at origin
> [20, 0]
> > [default_process_tiling_cl_roi] tile (1, 0) with 2303 x 3472 at origin
> [2302, 0]
> > [pixelpipe_process] [full] using device 0
> > [pixelpipe_process] [preview] using device -1
> >
> > Image with defringe:
> >
> > [default_process_tiling_cl_ptp] use tiling on module 'temperature' for
> image with full size 4585 x 3472
> > [default_process_tiling_cl_ptp] (2 x 1) tiles with max dimensions 4096 x
> 3472 and overlap 0
> > [default_process_tiling_cl_ptp] tile (0, 0) with 4096 x 3472 at origin
> [0, 0]
> > [default_process_tiling_cl_ptp] tile (1, 0) with 489 x 3472 at origin
> [4096, 0]
> > [default_process_tiling_cl_ptp] use tiling on module 'highlights' for
> image with full size 4585 x 3472
> > [default_process_tiling_cl_ptp] (2 x 1) tiles with max dimensions 4096 x
> 3472 and overlap 0
> > [default_process_tiling_cl_ptp] tile (0, 0) with 4096 x 3472 at origin
> [0, 0]
> > [default_process_tiling_cl_ptp] tile (1, 0) with 489 x 3472 at origin
> [4096, 0]
> > [default_process_tiling_cl_roi] use tiling on module 'demosaic' for
> image with full input size 4585 x 3472
> > [default_process_tiling_cl_roi] (2 x 1) tiles with max input dimensions
> 4096 x 3472
> > [default_process_tiling_cl_roi] tile (0, 0) with 2309 x 3472 at origin
> [20, 0]
> > [default_process_tiling_cl_roi] tile (1, 0) with 2303 x 3472 at origin
> [2302, 0]
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > October Webinars: Code for Performance
> > Free Intel webinars can help you accelerate application performance.
> > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> > the latest Intel processors and coprocessors. See abstracts and register
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> > _______________________________________________
> > darktable-devel mailing list
> > darktable-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/darktable-devel
> >
>
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
