Am Freitag, 1. November 2013, 19:38:49 schrieb Max Killer: > Hello, Hi.
> there is a bug in the current git which causes the exif data to get lost > from recently imported images. > > To reproduce (please do): > 0. Make sure use of embedded thumbnails is active in options > 1. Import images > 2. Close dt > 3. open dt and check the images. The exif data should be gone. > > I could track the problem to: > 464abb13fa454984251ea0abe1749d097682c151 - release cache before the lr > import circuitry. Thanks an awful lot for finding the bad commit. We owe you a beer or two. > Which makes sense to me (to someone like me who doesn't really know the > code of dt), because something is committed to the db before the exif > data is read. So it is lost. > But please try to reproduce. Exactly. The second problem is that we kept using the dt_image_t struct after the locks were released. I fixed both. [...] > Using half-size RAW as thumbnail seems to touch the files once while > importing, so the correct exif data is written to the db. But this is > only an educated guess. That's why at least I couldn't reproduce it. The program flow was something like this: - import the image - write stuff to db - read exif data - exit => exif data was lost. When not using jpeg thumbs the flow was: - import the image - write stuff to db - read exif data - process image - after processing the image the data is synced back to db (at least due to adding the "changed" tag) - exit => exif data was preserved. > so long, > hal Tobias
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
