Hi (again)
In the same thing of style plugin size, i think we can improve the size
of the tagging module
I don't mean to increase or decrease the total size of the plugin but
what content's in :
On the plugin, we have 2 list on :
1) tag apply on the picture ( we can see 7 tags on this list)
2) all tags from the library ( we can see 4 tags on this list)
Actually the 1) is bigger than 2)
But normaly the list 1) is much smaller than the 2)
Obvious, as i don't have knowledge in GTK, i have failed to found how
the size of each area is set on the tagging modlue, so i can't propose a
patch of it
Regards
Le samedi 09 novembre 2013 à 12:11 +0100, Roumano a écrit :
> Hi,
>
>
> It's a realy easy modification :
>
> One line modification on the file src/libs/styles.c
> On the Line 346, the size is actualy : 5*ht
>
> 5 it's corresponding to only 3 styles list
>
> replace the "5*ht" by "7*ht", we will have 5 style list.
>
> Regards
>
> roumano@roumano ~/bin/darktable/src/libs $ diff -u styles.c.old styles.c
> --- styles.c.old 2013-05-18 10:10:26.926915546 +0200
> +++ styles.c 2013-11-09 12:04:09.671917831 +0100
> @@ -343,7 +343,7 @@
> gtk_tree_view_column_add_attribute (col, renderer, "text",
> DT_STYLES_COL_NAME);
>
> int ht = get_font_height( GTK_WIDGET (d->list), "Dreggn");
> - gtk_widget_set_size_request (GTK_WIDGET (d->list), -1, 5*ht);
> + gtk_widget_set_size_request (GTK_WIDGET (d->list), -1, 7*ht);
>
> gtk_tree_selection_set_mode
> (gtk_tree_view_get_selection(GTK_TREE_VIEW(d->list)),
> GTK_SELECTION_SINGLE);
> gtk_tree_view_set_model (GTK_TREE_VIEW(d->list),
> GTK_TREE_MODEL(liststore));
>
>
> As you have persmission to commit, can you handle it ?
>
> Regards
>
> Le jeudi 07 novembre 2013 à 20:09 +0100, Pascal Obry a écrit :
> > Le 07/11/2013 19:25, Roumano a écrit :
> > > For me, on the ligthroom mode, the size of the style module is too
> > ^^^^^^^^^
> > lighttable :)
> > > small (or tiny), we can show only 3 stored style.
> > > So we have rapidly scroll a lot to found a style.
> > >
> > > What do you think about increase the size of this plug-in ?
> >
> > I would say that this is a good idea.
> >
>
>
>
>
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
