Hello,

jo thanks for the hint. I have been able to "adjust"
src/common/imageio_rawspeed.cc. after applying below small change the
Monochrom DNGs are displayed properly (not sure if overall darktable is
handling the data correctly now).
i am new to darktable with no idea of what evil whitchcraft i have
applied here :)

marcus


diff --git a/src/common/imageio_rawspeed.cc b/src/common/imageio_rawspeed.cc
index d9226a0..4c27a75 100644
--- a/src/common/imageio_rawspeed.cc
+++ b/src/common/imageio_rawspeed.cc
@@ -221,7 +221,7 @@ dt_imageio_open_rawspeed_sraw(dt_image_t *img,
RawImage r, dt_mipmap_cache_all
       for( int k = 0; k < 3; ++k )
         ((float *)buf)[4 * dt_imageio_write_pos(col, row, raw_width,
raw_height, raw_width, raw_h
           // ((float)raw_img[row*(raw_width + raw_width_extra)*3 +
col*3 + k] - black) * scale;
-          ((float)raw_img[row*(r->pitch/2) + col*3 + k] - black) * scale;
+          ((float)raw_img[row*(r->pitch/2) + col + k] - black) * scale;
 #endif
 
   return DT_IMAGEIO_OK;




On 11/29/2013 11:25 PM, schmidtfrog wrote:
> Hello,
>
> thanks for the hints!
>
> yes, rawstudio can open the file
> (https://www.dropbox.com/s/qo4v5hilv85myjp/snapshot2.jpg).
>
> I am not sure how the image information is stored in the DNG and how
> it is processed by darktable. I will try to have a look in
> imageio_rawspeed.
>
> marcus
>
>
>
>
> On 11/29/2013 02:58 AM, johannes hanika wrote:
>> heya,
>>
>> weird that it appears three times. doing some wrong bayer pattern
>> interpolation would mean to oversmooth details, but three copies
>> would be some sort of scanline/pixel storage order problem.
>>
>> anyways, i think some related modules would be:
>>
>> src/iop/temperature.c  (whitebalance)
>> src/iop/demosaic.c     (demosaicing)
>>
>> both of them should effectively pass through the data, the first one
>> could potentially need to promote it from 1x uint16_t per pixel to 1x
>> float per pixel, and the latter one should promote it to 4x
>> float/pixel so the rest of the modules can work on color data as they
>> expect it.
>>
>> can you open the image in rawstudio? those three copies look like
>> it's opened as an already-demosaiced color image that is wrongly
>> interpreted as 3 floats/pixel where we only get one.
>>
>> might be necessary to adjust src/common/imageio_rawspeed.cc to
>> understand that (in this case white balance and demosaic are probably
>> already doing the expected passthrough).
>>
>> cheers,
>>  jo
>>
>>
>>
>> On Thu, Nov 28, 2013 at 1:38 PM, schmidtfrog <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>     Hello (for the first time),
>>
>>     I have tried to open some DNGs from a Leica M Monochrom in Darktable
>>     (almost latest git master). Seems like some trouble due to the
>>     fact that
>>     a Bayer filter is missing in the cam. The actual image appears three
>>     times (see below screenshot).
>>
>>     https://www.dropbox.com/s/qpy4j481y20rdzk/snapshot1.jpg?n=223299317
>>
>>     Unfortunately I am not familar with darktable functions (had only a
>>     short look into the sources).
>>
>>     Nevertheless I would be happy if someone has a hint which
>>     function/files
>>     are worthwhile to check.
>>
>>     Marcus
>>
>>
>>
>>     
>> ------------------------------------------------------------------------------
>>     Rapidly troubleshoot problems before they affect your business.
>>     Most IT
>>     organizations don't have a clear picture of how application
>>     performance
>>     affects their revenue. With AppDynamics, you get 100% visibility
>>     into your
>>     Java,.NET, & PHP application. Start your 15-day FREE TRIAL of
>>     AppDynamics Pro!
>>     
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
>>     _______________________________________________
>>     darktable-devel mailing list
>>     [email protected]
>>     <mailto:[email protected]>
>>     https://lists.sourceforge.net/lists/listinfo/darktable-devel
>>
>>
>
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> darktable-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/darktable-devel

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to