About the #401 pull request.
Reviewing the code it seems to me that the current isldr status in the
preset table was never set to something other than 0 (don't care if ldr
or not).
This attribute is used in:
1. src/develop/develop.c:auto_apply_presets()
-> to apply into the history all the presets. Today as isldr=0 we
apply all matching presets.
2. src/develop/imageip.c:dt_iop_load_preset_interpolated_iso()
-> not used. Shouldn't it removed?
So, all in all my pull-request seems ok to me (at least non in
contradiction with some current code, meaning or usage).
The preset will have 3 settings:
- 0 -> apply to all images
- 1 -> apply to ldr images (ex: jpeg)
- 2 -> apply to RAW and hdr images
So, I'm proposing to merge this if there is no strong objection. Ok?
I'm just not clear about the GUI strings for the 3 settings above:
- for all formats
- for LDR only
- for RAW and HDR images
Something better? Not sure LDR is making sense to our users...
--
Pascal Obry / Magny Les Hameaux (78)
The best way to travel is by means of imagination
http://v2p.fr.eu.org
http://www.obry.net
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
