On Tue, 8 Apr 2014 13:32:00 Tobias Ellinghaus wrote:
> Am Dienstag, 8. April 2014, 14:38:21 schrieb Kevin:
> 
> [..]
> 
> I didn't have time to look at your patch, but if you want to have a chance
> of seeing this included you have to remove
> 
> >                       -i|--input <input file>
> >                      
> >                      -o|--output <output file>
> >                     
> >                     [-x|--xmp <xmp file>]
> 
> and go back to the old behaviour. Maybe then I will take some time to review
> it. And the --style is something I am also not convinced of. If you want
> canned processing just put it into an XMP.

As requested I have removed the -i, -o and -x parameters. Almost.

I'm still against positional parameters: they violate my view of the 
philosophy of Unix. So the attached file contains the following two patches:

1) cli_positional.patch - old style positional parameters only.
2) cli_both.patch - a mixture of both, file paths can be specified by 
positional 
parameters or by the -i, -o and -x parameters - but not both. This, IMO, 
represents an acceptable compromise. Existing scripts or patterns of usage 
will still operate correctly while there is the freedom to specify parameters 
in whatever order is desired.

I have no such strong views regarding the "--style" parameter so there are to 
additional patches, each based of the above two that removes that parameter:

3) cli_positional_no_style.patch
4) cli_both_no_style.patch

Kevin

Attachment: cli_patch.tar.gz
Description: application/compressed-tar

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to