Thanks for testing Brian,

On Thu, Apr 17, 2014 at 7:56 PM, Brian Teague <tea...@mit.edu> wrote:
> My use-case may be a little strange.  Photography is a hobby, not a job, so
> I don't have a monster computer for editing.  What I do have is a snappy
> 4-core (8-thread) i7 with a 256 Gb SSD; the majority of the library (~2 Tb
> of RAWs) is stored on a NAS on the other side of a gigabit network link
> (along with the rest of my media.)

I have a friend who uses a similar setup. It's hard to get lots of
storage these days in a laptop. All the good stuff tends to have SSDs.
Keeping the cache separate from the images makes it easier to put the
cache in the SSD for better speed.

> I don't mind waiting a few seconds for an image to load when I go to edit
> it.  What drives me nuts, though, is scrolling through my library and
> waiting .... and waiting ..... and waiting for the thumbnails to regenerate.
> Especially with an SSD for the cache drive, I'm more than willing to pay for
> some space to make browsing my library fast.
>
> I did run into a few bugs:
>
>  - I do have a tendency to like different thumbnail sizes for different
> tasks: when I'm having the first look at a day's shooting I'll have 2-3
> images in a row, but when I'm looking back through old material it's
> generally 6-8.  As Pedro already noted, when I change LT zoom level the
> thumbnails get regenerated: I would be highly in favor of generating them
> all at once and then spitting them out to disk.  (And really, once you
> generate the biggest one, the rest are just quick 2^n-fold scales, right?)
> I can see how there's some win in only generating a little thumbnail if you
> don't need the big one, but when the majority of my time is getting the
> image off of the remote disk, the difference is pretty negligible.

Right, with the current patch the MIP levels are all separate caches.
So if you resize you have a cold cache again and everything needs to
be regenerated. My suggestion in the last email was to consolidate the
thumbnail levels into a single cache and generate them all at once, or
just have the highest level and scale that one down to size.

>  - I was scrolling through a large collection so as to generate the
> thumbnails, then evict them from the cache to disk so I could see if they
> loaded again properly.  They did, but frequently the first two or three rows
> would be grey -- and then as I continued scrolling, they'd appear.

I've seen this too and think it's a general lighttable bug. But it
could also be broken locking in my patch.

>  - I did run into a situation (after changing zoom levels a few times) where
> the wrong level of MIP level was displayed (ie, the zoom was quite large but
> the smaller thumbnail, scaled, was displayed.)

It was probably using the smaller MIP level while it generated the
larger one. Did it eventually fix itself?

>  - If I scrolled rapidly through a region that had been evicted, I could
> pretty reliably get it to hang.  I didn't have a chance to attach GDB and
> see where it was hanging.  No crashers, though.

Then the locking is probably wrong. The only suspect place I know of
is getting a write lock on the cache when paging it back in from disk.
But I may have screwed up something else.

> I'm not likely to have time to help actively with development, but I'm happy
> to continue testing.  (-:

Thanks for the report,

Pedro

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to