As a follow up on this, compiling with libpng version 1.6.10 worked fine.
The issue appears to be with how the master branch interacts with libpng 1.4.x. If someone on the development team can replicate this, perhaps the configure script should complain if the latest version of libpng is 1.4.x? (I first tried to upgrade to 1.4.13, which was released earlier this year, but it did not fix the issue.) Regards, James Marca On Thu, May 08, 2014 at 02:27:20PM -0700, James E. Marca wrote: > Hi, > > I've been compiling the 1.4.x version of Darktable without issue. > Today I tried compiling the latest (git master) version of darktable > and the compilation failed with: > > [ 32%] Building C object > src/CMakeFiles/lib_darktable.dir/common/imageio_module.c.o > In file included from /usr/include/png.h:426:0, > from /tmp/darktable/src/common/imageio_png.c:28: > /usr/include/pngconf.h:1478:25: error: attempt to use poisoned "strcpy" > # define png_strcpy strcpy > ^ > make[2]: *** [src/CMakeFiles/lib_darktable.dir/common/imageio_png.c.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [src/CMakeFiles/lib_darktable.dir/all] Error 2 > make: *** [all] Error 2 > > >From doing a very small amount of searching for the error message, it > appears that something like this: > http://blog.leafsr.com/2013/12/02/gcc-poison/ > is being triggered? > > The 1.4.x branch compiles just fine. Latest commit > commit 5c7de5e814f033b6a1f661b9c428b1509d5aac88 > Author: parafin <para...@paraf.in> > Date: Tue Apr 22 20:57:17 2014 +0400 > > Only the master branch fails to compile. > > I am on Slackware 14.1/current, and the libpng is really old (1.4.2) > so perhaps that is the source of the problem? I will explore that > too, but arbitrarily upgrading libpng is liable to break lots of things. > > Has anyone else hit this compilation issue? > > Regards, > James Marca > ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
