Sorry for not reporting this earlier - I'm not familiar with darktable
code and certainly not an expert in C code... I did replay all changes
induced by the "faulty" commit and found out that the removal of
thumbnail_width and thumbnail_height variables declaration in
src/common/darktable.h is causing the issue. 
If I just restore line 174:
  int32_t thumbnail_width, thumbnail_height;
it works anew under the 0a00f6126a95984b959c19f5e4a1ecc89c8e4fed commit.

My guess is that: 

- somehow these variable are referenced somewhere else in the code via
some indirection (Pointer with offset in the darktable_t struct?
Otherwise we'd have some compile time syntax error...?)
- this trigger an issue on some people runtime conditions...

So to complete the investigation, I went back to master,
src/common/darktable.h and re inserted the line:
  int32_t thumbnail_width, thumbnail_height;
immediately before the "unmuted" variable declaration. Build, and now it
works fine, darktable opens up normally.

Hope it helps,
-Francois

Le dimanche 04 janvier 2015 à 01:13 +0100, thokster a écrit :
> Remove thumbnail_width/height settings   
> 0a00f6126a95984b959c19f5e4a1ecc89c8e4fed
> 
> introduces the issue over here
> 
> 
> 
> Am 03.01.2015, 23:36 Uhr, schrieb Francois Connetable  
> <francois.conneta...@free.fr>:
> 
> > FYI, reverting to a "randomly selected" commit from DEC24:
> > af6ffb25e9b75f4b8fb5bcc24510c374e4e8d59b
> >
> > ...Everything is fine again. So I'll do some further try to see if I can
> > find out the commit id that introduces the issue..
> >
> > -Francois
> >
> > Le samedi 03 janvier 2015 à 23:30 +0100, Francois Connetable a écrit :
> >> Just to confirm, I upgraded my ubuntu to "vivid". I'm now running
> >> libgtk-3.14.6. I did a full rebuild of darktable -> still the same
> >> issue. Will try to revert to a previous commit and see if I can get it
> >> to run again...
> >>
> >> Not sure it can explain but my system went through an update to latest
> >> nvidia driver before the issue started to occur...
> >>
> >> -Francois
> >>
> >>
> >> Le dimanche 04 janvier 2015 à 06:27 +1300, johannes hanika a écrit :
> >> > we /think/ 3.10 should suffice, but of course can't be sure without
> >> > further testing. gtk changed the threading model, and since these
> >> > backtraces all show some gdk_threads_enter() related stack traces
> >> > that's my best guess so far.
> >> >
> >> > running gtk-3.14 just fine here..
> >> >
> >> >
> >> > -jo
> >> >
> >> >
> >> > On Sun, Jan 4, 2015 at 6:22 AM, Francois Connetable
> >> > <francois.conneta...@free.fr> wrote:
> >> >         Hi Jo,
> >> >
> >> >         Assuming this is what your are looking for, a "dpkg -l
> >> >         libgtk-3-0" reports:
> >> >         3.12.2-0ubun amd64
> >> >
> >> >         Now it makes me wonder - didn't you say that 3.14 was the
> >> >         minimum version supported?
> >> >
> >> >         Thanks for your help,
> >> >         -FrancoisLe 3 janv. 2015 18:05, johannes hanika
> >> >         <hana...@gmail.com> a écrit :
> >> >         >
> >> >         > which version of libgtk-3 do you guys have where it hangs?
> >> >         >
> >> >         > -jo
> >> >         >
> >> >         > On Sun, Jan 4, 2015 at 4:28 AM, Francois Connetable
> >> >         <francois.conneta...@free.fr> wrote:
> >> >         >>
> >> >         >> Same thing here (running on GNOME ubuntu latest, NVIDIA
> >> >         openCL).
> >> >         >>
> >> >         >> Hope it helps,
> >> >         >> -Francois
> >> >         >> Le 3 janv. 2015 11:25, Alexander Rabtchevich
> >> >         <alexander.v.rabtchev...@gmx.net> a écrit :
> >> >         >> >
> >> >         >> > Hello
> >> >         >> >
> >> >         >> > I can only see a dark rectangle of the program instead of
> >> >         its controls.
> >> >         >> > Pressing L, D, F11 changes nothing. gdb shows no problems
> >> >         and the
> >> >         >> > program does nothing at least it does not consume
> >> >         processor power.
> >> >         >> > Current git. Deletion of library file hasn't helped.
> >> >         >> >
> >> >         >> > With respect,
> >> >         >> > Alexander Rabtchevich
> >> >         >> >
> >> >         >> >
> >> >          
> >> ------------------------------------------------------------------------------
> >> >         >> > Dive into the World of Parallel Programming! The Go
> >> >         Parallel Website,
> >> >         >> > sponsored by Intel and developed in partnership with
> >> >         Slashdot Media, is your
> >> >         >> > hub for all things parallel software development, from
> >> >         weekly thought
> >> >         >> > leadership blogs to news, videos, case studies, tutorials
> >> >         and more. Take a
> >> >         >> > look and join the conversation now.
> >> >         http://goparallel.sourceforge.net
> >> >         >> > _______________________________________________
> >> >         >> > darktable-devel mailing list
> >> >         >> > darktable-devel@lists.sourceforge.net
> >> >         >> >
> >> >         https://lists.sourceforge.net/lists/listinfo/darktable-devel
> >> >         >>
> >> >          
> >> ------------------------------------------------------------------------------
> >> >         >> Dive into the World of Parallel Programming! The Go
> >> >         Parallel Website,
> >> >         >> sponsored by Intel and developed in partnership with
> >> >         Slashdot Media, is your
> >> >         >> hub for all things parallel software development, from
> >> >         weekly thought
> >> >         >> leadership blogs to news, videos, case studies, tutorials
> >> >         and more. Take a
> >> >         >> look and join the conversation now.
> >> >         http://goparallel.sourceforge.net
> >> >         >> _______________________________________________
> >> >         >> darktable-devel mailing list
> >> >         >> darktable-devel@lists.sourceforge.net
> >> >         >>
> >> >         https://lists.sourceforge.net/lists/listinfo/darktable-devel
> >> >         >
> >> >         >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Dive into the World of Parallel Programming! The Go Parallel Website,
> > sponsored by Intel and developed in partnership with Slashdot Media, is  
> > your
> > hub for all things parallel software development, from weekly thought
> > leadership blogs to news, videos, case studies, tutorials and more. Take  
> > a
> > look and join the conversation now. http://goparallel.sourceforge.net
> > _______________________________________________
> > darktable-devel mailing list
> > darktable-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/darktable-devel



------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to