FYI, I've made a few very small changes to the histogram.
These changes
* remove the text which I think gets in the way and distracts
more than is helpful,
* raises the contrast and visibility of the curves,
* changes the background to black for better visibility
I think most would find it to be an improvement. If the developers
feel like it is a worthy change, I'd like to see it added to the
source tree.
These changes were made to just one file (src/libs/histogram.c) from
version 1.6.4 .
--------------------diff historam.c histogram.c.orig------------------
319c319
< cairo_set_source_rgb(cr, .0, .0, .0);
---
> cairo_set_source_rgb(cr, .3, .3, .3);
334a335,342
> // draw grid
> cairo_set_line_width(cr, .4);
> cairo_set_source_rgb(cr, .1, .1, .1);
> if(dev->histogram_type == DT_DEV_HISTOGRAM_WAVEFORM)
> dt_draw_waveform_lines(cr, 0, 0, width, height);
> else
> dt_draw_grid(cr, 4, 0, 0, width, height);
>
370c378
< cairo_set_source_rgba(cr, 1., 0., 0., 1.0);
---
> cairo_set_source_rgba(cr, 1., 0., 0., 0.2);
375c383
< cairo_set_source_rgba(cr, 0., 1., 0., 1.0);
---
> cairo_set_source_rgba(cr, 0., 1., 0., 0.2);
380c388
< cairo_set_source_rgba(cr, 0., 0., 1., 1.0);
---
> cairo_set_source_rgba(cr, 0., 0., 1., 0.2);
389,396c397,412
< // draw grid
< cairo_set_operator(cr, CAIRO_OPERATOR_OVER);
< cairo_set_line_width(cr, .4);
< cairo_set_source_rgb(cr, .5, .5, .5);
< if(dev->histogram_type == DT_DEV_HISTOGRAM_WAVEFORM)
< dt_draw_waveform_lines(cr, 0, 0, width, height);
< else
< dt_draw_grid(cr, 4, 0, 0, width, height);
---
> cairo_set_source_rgb(cr, .25, .25, .25);
> cairo_select_font_face(cr, "sans-serif", CAIRO_FONT_SLANT_NORMAL,
> CAIRO_FONT_WEIGHT_BOLD);
> cairo_set_font_size(cr, .1 * height);
>
> char exifline[50];
> cairo_move_to(cr, .02 * width, .98 * height);
> dt_image_print_exif(&dev->image_storage, exifline, 50);
> cairo_save(cr);
> // cairo_show_text(cr, exifline);
> cairo_set_line_width(cr, 2.0);
> cairo_set_source_rgba(cr, 1, 1, 1, 0.3);
> cairo_text_path(cr, exifline);
> cairo_stroke_preserve(cr);
> cairo_set_source_rgb(cr, .25, .25, .25);
> cairo_fill(cr);
> cairo_restore(cr);
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
