Dear all,

I have found a bug in noiseprofile.c.

The bug code as following.

std[bin][c] += median(llhh+2*begin, end-begin)/0.6745; 

 

As you can see, above std[bin][c] does not accumulated.

I used printf function to probe as following code.

printf("acc_std:%f std:%f cnt:%f bin:%d c:%d \n",std[bin][c],(kk) 
,cnt[bin][c],bin,c ); 

 

and result as following.

acc_std:0.000051 std:0.000051 cnt:1058.000000 bin:0 c:0 

acc_std:0.000113 std:0.000113 cnt:4416.000000 bin:1 c:0 

acc_std:0.000226 std:0.000226 cnt:3520.000000 bin:2 c:0 

acc_std:0.000294 std:0.000294 cnt:3057.000000 bin:3 c:0 

acc_std:0.000339 std:0.000339 cnt:3197.000000 bin:4 c:0 

acc_std:0.000633 std:0.000633 cnt:2325.000000 bin:5 c:0 

acc_std:0.000814 std:0.000814 cnt:2230.000000 bin:6 c:0 

acc_std:0.000905 std:0.000905 cnt:2736.000000 bin:7 c:0 

...

 

As you can see that above, acc_std does not increase.

it seems to be a bug. If not , Please let me know.

Does anyone let me know whether this is a bug or not?.

 

cheers  
 
Following code is that i used code in noiseprofile.c.
 
...
kk = median(llhh+2*begin, end-begin)/0.6745;
std[bin][c] += median(llhh+2*begin, end-begin)/0.6745;
cnt[bin][c] = end - begin;
printf("acc_std:%f std:%f cnt:%f bin:%d c:%d \n",std[bin][c],(kk) 
,cnt[bin][c],bin,c );
...


------------------------------------------------------------------------------
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to