> > /data/code/git/darktable/src/common/interpolation.c: In function
> > âdt_interpolation_compute_sampleâ:
> > /data/code/git/darktable/src/common/interpolation.c:789:21: error: array
> > subscript is above array bounds [-Werror=array-bounds]
> > h += kernelh[j] * ipixel[0];
> > ^
> > cc1: all warnings being treated as errors
> >
> > Fedora 22 is using gcc 5.1.1, according to 'gcc --version'.
>
> So far, we consider this to be a gcc bug.
> Feel free to report it to report it to fedora/$(DISTRO_NAME)/gcc bugzilla.
I've now reported this to the Fedora 22 people as:
https://bugzilla.redhat.com/show_bug.cgi?id=1236784
Hopefully they will agree that this is a gcc bug and do something
about it.
In terms of bounds analysis here, in case I have to discuss this with
the Fedora people: since bordermode is forced to not be BORDER_CLAMP
in this branch, prepare_tap_boundaries() will set xtap_first to 0 and
xtap_last to 2 * itor->width, and itor->width is asserted as less than
4 at the start of the function. Thus we can't go outside the 0..7 range
of the kernelh[8] array. Is that a correct analysis or am I missing
something subtle?
I checked and the official Fedora 1.6.7 darktable package builds
fine with their version of gcc. This is kind of odd, because the relevant
code seems to be exactly the same. The build environment may be different
in a RPM build versus being done through build.sh, or maybe something
else changed.
(I checked because I figured it might be easier to report a 'failed to
build from source due to gcc problem' error on an existing Fedora package
than 'here's a gcc problem exposed by a not-currently-packaged thing'.)
- cks
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
