On Tue, Jan 22, 2013 at 6:00 AM, <[email protected]> wrote: > I was excited to see in the release notes for version 1.1.2 that the white > balance presets for the Canon EOS 550D would be updated. I liked the > existing presets, and was interested to see what might be added. However, > now all I see are the three basic settings: camera whitebalance, spot > whitebalance and passthrough. All of the other presets, like Daylight, > Cloudy, Shade and so on have disappeared. I also cannot figure out how to > make use of the slider labelled 'finetune'. I cannot make it move at all.
The finetune sliders only works for daylight, etc. > My camera is actually Canon EOS T2i, which I always thought was identical to > EOS 550D. I think this is correct. > After downloading the most recent git version, so I could check for any > updates, I found no changes. I am not a C programmer. However, I decided > to have a look in the code to see what looked amiss. I found the settings in > wb_presets.c, then found that the caller uses EXIF information to select the > correct settings. On a hunch, I had a look at my EXIF info and saw "EOS > REBEL T2i" as the model, but in wb_presets.c the values were "EOS Rebel T2i". > I changed 'Rebel' to 'REBEL' and rebuilt the code, and now I see the presets. Aha :) So I just committed a fix based on your analysis: https://github.com/darktable-org/darktable/commit/5f07da79d80aa71145629e7c0b4c0cf06fd0dff9 > Thank you for all your hard work in this wonderful project, and the > opportunity for me to feel like I might be able to make a contribution, > however small. I read the style guide and saw that if I followed procedure I > should make a fork, but this is beyond my ability. Please excuse me > suggesting this change in this forum. It's fine. No worries. Thanks for your help! Regards, Pascal de Bruijn ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ Darktable-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-users
