Hi Am 04.06.2015 um 18:40 schrieb Roman Lebedev: > On Thu, Jun 4, 2015 at 7:19 PM, Ulrich Pegelow > <ulrich.pege...@tongareva.de <mailto:ulrich.pege...@tongareva.de>> wrote: > > Definitely looks like a bug. Same happens here with other images as > well. > > The root cause seems to be the "flip" function in crop&rotate. It > produces a white (?) line at the left of the roi when activated with > mode "horizontal", on the top of the roi with mode "vertical" and on > both sides if the two are combined. The shadow&highlights module makes > this white line more visible. > > Here is how to best see: > > 1) open image in darkroom (ideally an image with homogeneous color, e.g. > blue sky) > 2) zoom into image (e.g. 200%) > 3) activate crop&rotate with horizontal flip > 4) switch on shadows&highlights with radius 200 > 5) move the roi around: at each position you see the left side being > lighter than it should > > So we have a likely problem with the roi calculation in the module which > is most complex in this aspect :( > > Hi. > I have seen similar c&r issue happening because of c&r flip feature: > https://www.dropbox.com/s/gm9n6l9dgibmy7e/out-5.ogv?dl=0 > > And there is even a fix: > https://github.com/darktable-org/darktable/compare/master...AlicVB:mask_jump
Checked it but it doesn't seem to solve the issue. > > > But: > [00:07:28] <alicvb> LebedevRI: I've create the branch : > https://github.com/AlicVB/darktable/tree/mask_jump but as it can change > old image, even at 100% export, I'm really not sure it's ok to push it > The proper solution for that would be a version bump of the module with a (hidden) parameter (e.g. "float rounding_offset") which is 0.0f for any legacy history stack and 0.5f for any new one. But as said, it doesn't seem to fix the issue of the white line. Ulrich > (i have cc'd alicvb because of the branch) > > > Ulrich > > Roman. > > ------------------------------------------------------------------------------ _______________________________________________ Darktable-users mailing list Darktable-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-users
