Ziemowit Laski wrote:

>>
>>            /* APPLE LOCAL Objective-C++ */
>>   -        { $$ = get_class_ivars ($3); }
>>   +        { $$ = get_class_ivars_from_name ($3); }
>
>
> We can do this, but perhaps it would be simpler if we checked for
> the existence of the class inside of 'get_class_ivars' ?

I suppose so.  I was thinking that get_class_ivars and
get_class_ivars_from_name have different "signatures",
but it wouldn't hurt (except for a tiny speed cost :-) ) to
test inside get_class_ivars.

>>    /* Used by: build_private_template, continue_class,
>>       and for @defs constructs.  */
>>
>>   @@ -4075,8 +4094,7 @@
>>      else
>>        UOBJC_CLASS_VARIABLES_decl = 0;
>>
>>   -  /* APPLE LOCAL bitfield alignment */
>>   -  chain = CLASS_OWN_IVARS (implementation_template);
>>   +  chain = CLASS_IVARS (implementation_template);
>
> Are you sure this is correct?  I'm not sure that it's not :-(, so
> I'll take a closer look at the sources before I talk.

I'm not sure either, but empirically, CLASS_OWN_IVARS is
not filled in by finish_struct while CLASS_IVARS is.  Perhaps
they should both be filled in?

Stan


Reply via email to