Hi Bernerd,

> I see you reverted my commit. Hopefully we can figure out how to
> actually fix this -- the changes that were made were called for by
> other bugs which had been posted (where lazy-load would never load
> properties not inside of your :fields specification).

I reviewed that ticket and make sure that I fixed the bug after
reverting your change.  I'd never just revert a change without coming
up with an alternative fix, although I probably could've commented it
better. :)

Here's the commit that fixes the bug your commit originally fixed:
(except it doesn't have the same side effect with Query#update)

http://github.com/sam/dm-core/commit/a413f73d744749e24b2ac3d8a1028f14d47297b7

Basically, Resource#inspect was lazy loading not-loaded, non-lazy
properties.  (hope that makes sense)  What it should've been doing is
not lazy loading any fields and display "<not loaded>" for anything
not already loaded.  It make some incorrect assumptions, which I think
was my fault since I originally wrote Resource#inspect.

IRB and Resource#inspect have always been a bit of a pain, and this
fix solves a whole host of related issues at the same time.

Dan
(dkubb)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"DataMapper" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/datamapper?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to