Hi Jon, > Its actually very nice to use blocks, and I can see how this was > initially coded that way. Its clean and neat. But coding this type of > behavior by having an abstract model that your model inherits from > give you lots of benefits. The first being that in this case, the > behavior would not be a bug.
If you want to put together a patch with your suggestions please do. Once you do, feel free to either send me a pull request on github or make a ticket at http://datamapper.lighthouseapp.com (tickets are probably preferred because then there's no chance of me being the bottleneck). Make sure to include [PATCH] in the subject, and make sure it's tagged with at least the "patch" tag so that we can identify and apply it more quickly. In dm-timestamps there's a spot where it has a helper method that defines the property. Making the mutator private there might be something to consider. I don't know if the accessor should be private though, as I can think of a few cases where I've used created_at/ updated_at in controller code (for example to handle Conditional GET requests, returning 304 if the resource isn't modified). Dan (dkubb) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
