I have to agree that create returning an unsaved object is awkward. This goes back to my earlier opinion on exceptions. The biggest issue is that it's inconsistent with the save method.
I also disagree with the philosophy of constantly telling people to implement plug-ins for small API changes: - The last thing DM needs is a ton of plug-ins that subtly modify core behaviors. This would lead to compatibility nightmares and is unmaintainable. Plug-ins add functionality. They should not reopen core classes and modify their behavior. - No one will install a such a plug-in unless it's a serious pain point. This is too minor to warrant that effort in the face of all sorts of maintenance problems. It would also be rare that someone would find out about the plug-in. Just because it doesn't justify a plug-in doesn't mean it doesn't justify changing. - Debating better ways to do things is healthy. The status quo of the implementation should be questioned when appropriate - with or without alternative code - especially before 1.0. Debate is the first step to creating better implementations. - Suggesting someone create a plug-in seems to be a crutch to avoid thoughtful discussion. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
