Hi Jacques, > We need to get this into dm-more. The plugin is well spec'ed. Maybe we > should tweak the interface, I'm not sure. Dan, can you take a look and > see if its to your liking?
I'm not entirely sure I want to focus on adding more to dm-more. atm, there's quite a few plugins that have little use that I'd like to push out to the author's git repo, and/or split into their own repos (such as one for adapters). I would rather focus on slimming down dm-more to just the essentials, and then only add things that are widely used/ needed to dm-more. At the same time I think we could do a better job of tracking DataMapper plugins outside of dm-core and dm-more. I suppose a wiki page will do in the interim as a way of just getting the names/ descriptions/locations all in one place, but it would be nice to have some sort of directory like what's available for RoR plugins. Please don't take this to mean I don't like the plugin. If I need to do a counter cache I'll probably look at it. I do have a couple of stylistic changes I would make if I were maintaining it, such as moving the counter cache declaration from the belongs_to() to the has () call. It would be a bit tricky though because it would have to deal with cases where the target (child) model hasn't been loaded yet, so it would have to be able to defer adding the after :create and :destroy hooks until the class was available. (and tbh I don't have a clean solution to this yet.. it's an issue I am wrestling with in dm-core/next) I'd probably also try to make it so declaring the counter creates the counter property in the current model, if it's not already defined. Dan (dkubb) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
