Tony, Thinking further about the merb-auth-more issue, I haven't noticed any deprecation warnings about new_record? Also, merb_datamapper provides an alias :new_record? :new? so I'd be surprised if you get a warning about new_record? specifically. In the meantime, Yehuda has pulled my latest patches, so if you could try out wycats/merb/master or wycats/merb/1.0.x and see if you still get these warnings, that would be cool :)
cheers snusnu On Tue, Sep 22, 2009 at 23:57, Martin Gamsjaeger <[email protected]> wrote: > Tony, > > Thx for pointing out the merb-auth-more issue, I'll have a look at it. > Concerning the YAML / CSV / Text issues, I'm pretty sure there's a > ticket about something like it on the datamapper lighthouse. I can't > remember it's state, but I'm pretty sure there is one. > > > On Tue, Sep 22, 2009 at 22:35, Tony Mann <[email protected]> wrote: >> Another issue I am seeing is with the Yaml type. It uses the String >> primitive type with a length of 64K, which is not allowed in MySQL (max is >> about 20K). I had a monkey-patch to make Yaml use the Text primitive, but >> that primitive type no longer seems to be available (Text is now a derived >> type that uses the String primitive). If that is true, then CSV will also >> break since it uses the Text type, but I have not tested that yet. >> For now, the patch is to change migrations.rb to map Yaml to TEXT (which is >> what happens with the Text type). But I want to see if there is a "right" >> way to do this. >> ..tony.. >> >> On Tue, Sep 22, 2009 at 1:25 PM, Tony Mann <[email protected]> wrote: >>> >>> It looks like merb-auth-more is still causing deprecation warnings (for >>> new_record? method calls), even with the snusu patched version. Anyone else >>> seeing that? If so, we should patch this before 1.0.13 comes out. >>> ..tony.. >>> >>> On Tue, Sep 22, 2009 at 1:11 PM, Martin Gamsjaeger <[email protected]> >>> wrote: >>>> >>>> Yehuda, >>>> >>>> I have one more fix for merb_datamapper and a small change to the >>>> merb/merb/Rakefile in my 'fixes' branch at >>>> http://github.com/snusnu/merb/commits/fixes >>>> >>>> The merb_datamapper fix allows to run the rake migration tasks, and >>>> the fix to the Rakefile silences an error when running 'sudo rake >>>> install' in the toplevel merb directory. >>>> >>>> I already sent you a pull request for the merb_datamapper issue, iirc. >>>> I'm writing this here again, because i moved both the old change and >>>> the newer one into a separate branch on top off current master. If >>>> you're applying the changes from >>>> >>>> http://github.com/snusnu/merb/commits/fixes >>>> >>>> the pull request will become obsolete. >>>> >>>> cheers >>>> snusnu >>>> >>>> On Tue, Sep 22, 2009 at 21:01, Yehuda Katz <[email protected]> wrote: >>>> > We should be able to do a 1.0.13 this week with these small changes. >>>> > kupa's >>>> > bundler changes on master might also justify finally releasing 1.1. >>>> > -- Yehuda >>>> > >>>> > On Tue, Sep 22, 2009 at 11:59 AM, Ashley Moran >>>> > <[email protected]> wrote: >>>> >> >>>> >> >>>> >> On 22 Sep 2009, at 19:19, Martin Gamsjaeger wrote: >>>> >> >>>> >> > Ashley, >>>> >> > >>>> >> > That limitation actually doesn't apply anymore, since teamon has >>>> >> > been >>>> >> > so kind to backport my changes (which are now in merb/master) to >>>> >> > merb-1.0.12. Have a look at >>>> >> > >>>> >> > http://github.com/snusnu/merb/commits/1.0.x-dm-0.10.0 >>>> >> > >>>> >> > for a dm-0.10.0 compatible version of merb-1.0.12 >>>> >> > >>>> >> > cheers >>>> >> > snusnu >>>> >> >>>> >> Hi Martin aka snusnu >>>> >> >>>> >> Thanks for the info >>>> >> >>>> >> Will this get a new version number, eg 1.0.12.1? One of the problems >>>> >> we had with DataMapper RCs using the same version number is that RC2 >>>> >> didn't install over the top of RC1 until we did an uninstall. This >>>> >> caused a moderate amount of head-scratching, that may also affect >>>> >> current Merb 1.0.12 users. >>>> >> >>>> >> Cheers >>>> >> Ashley >>>> >> >>>> >> -- >>>> >> http://www.patchspace.co.uk/ >>>> >> http://www.linkedin.com/in/ashleymoran >>>> >> http://aviewfromafar.net/ >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> > >>>> > >>>> > >>>> > -- >>>> > Yehuda Katz >>>> > Developer | Engine Yard >>>> > (ph) 718.877.1325 >>>> > >>>> > > >>>> > >>>> >>>> >>> >> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
