I don't see your comments ;) Did you forget to push? :P
On 17/10/2011, at 5:23 PM, Emmanuel Gomez wrote: > On Oct 16, 2011, at 11:12 PM, Chris Corbyn wrote: >> TBH, the code can probably be improved to load DataMapper collections >> referencing the Query for the relationship instead of just load Arrays. It >> would be more correct this way. I'll have a look at that later. It was >> late last night when I looked at this ;) >> >> For the purposes of iteration this works fine though. It would only fall >> down if you tried to invoke a method like #create, #new or #all on one of >> the eager-loaded collections. >> >> Will post back later. > > Chris, that looks very cool. > > I've added a few comments on the gist with a couple of thoughts. > > —Emmanuel > > -- > You received this message because you are subscribed to the Google Groups > "DataMapper" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/datamapper?hl=en. > -- You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/datamapper?hl=en.
