Hello Rick, On Mon, Mar 24, 2003 at 11:19:45AM +1100, Rick Measham wrote: > Attached is the first Beta of DateTime::Event::Easter. Play with it. Poke > it. If something doesn't work like you expect, or you want it to work > differently, let me know.
I appreciate the way your module tries to optimize running time by memoizing results of calculations. This, however, is a potential memory leak. Only applications asking for the same calculations over and over will draw notable benefit from it. Therefore, I would rather have the module just do the calculations and let the application take care of memoizing (if appropriate) elsewhere. In order to simply speed up the process of calculating several dates with different constant offsets from one specific Easter Sunday it already would help to store the year and Easter date of one calculation in the DateTime::Event::Easter object. As in that case the memory footprint would be a small constant, I would not object. By the way, I wonder if the eastern Orthodox actually use astronomical observations for the moon cycle but not for the equinox. If the rule is astronomical in every respect you will of course get Easter Sundays at arbitrary Gregorian dates, not only in April or late March. -Martin
