> 
> Dave Rolsky wrote:
> > 
> >   $VERSION = qw($Revision: 0.01 $) [1];
> > 
> > That's not CVS, is it?  If it is, please don't use it's 
> revision numbers
> > directly (this is discussed in the dev docs I wrote).

No, it is not CVS. This is the way it was in the Astro::Sunrise module
I can't remember where I got it from.
> 
> And even if Dave hadn't prohibited that mode of operation, 
> the above code is not 
> backwards compatible to 5.005_03, which emulates qw() using 
> split.  This would 
> be correct, though (note the movement of the parens):
> 
>       $VERSION = (qw$Revision: 0.01 $)[1];

Thanks John!! I have changed the module to use this syntax

> 
> although this is even better (IMNSHO):
> 
>       use version;
>       $VERSION = new version qw$Revision: 0.01 $;
> 
> see
> 
>       http://search.cpan.org/author/JPEACOCK/version-0.28/
> 
> John

Reply via email to