On Fri, 20 Jun 2003, Joshua Hoblitt wrote: > DT::TZ::LINKS is still the only internal structure that is modified.
Yes, but you access @DT::TZ::ALL as well. > > almost certainly does not belong in a module called Alias! Why does > > it > > Probably not - but what ever module handles the aliasing should have a > complete interface as it's all related functionality. This was missing > elsewhere. Maybe we should talk about moving this into the DT::TZ dist. Yes, we should. I don't object to some sort of "is_olson_timezone" method for DT::TZ. > > have the timezones() method which completely duplicates the functionality > > of DateTime::TimeZone::all_names()! > > Because all_names() returns a direct reference to the data structure and > I was worried about protecting the internals. And as I stated above > it's all related functionality. Send me a patch, don't just implement a totally redundant method in another module. That's silly. > > All of the stuff about dying if an alias is defined and so on seems > > like total overkill. The purpose of this module, AFAIC, is for > > individual end-users to be able to define some useful _local_ aliases, > > in an > > This is related to comments made about using this module under mod_perl. > I think it's clear that a lot of people will use this to handle > localization of timezones (like what EST is defined as). You mean localize it differently on different requests under mod_perl? > > environment _they_ control. No one should ever be distributing a CPAN > > module that uses this, and distributing an app that does this by > > default would almost certainly be a bad thing too. > > But they will... And why shouldn't someone be able to define what > timezone X means to them in a distributed app? I this passes the 'is it > useful' test. Sure, we can give them enough rope, but I don't want to include code aimed at dubious uses. This is the same reason I want DateTime constructors to always validate input. -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/
