That makes sense. Let me make sure I have this correct: Change day_of and week_of methods to check if there are arguments, if not, return those current values or throw and error if not yet defined.
Add a quarter_of method with the same API. On Fri, 4 Jul 2003, Dave Rolsky wrote: > On Thu, 3 Jul 2003, Jesse Shy wrote: > > > Yes, please, tell me what to change. I dont know what it should have been. > > I looked at the date time module and the DateTime-TimeZone modules for > > examples and read the standards from the web site. So I used named > > parameters, did I miss something that should have been obvious? I am not > > sensitive, I am here to get better ( and maybe contribute something > > useful). > > It's the API that's not right. It doesn't match the existing DateTime.pm > API. For example, DateTime.pm does not have any methods starting with > "get_". Additionally, your "get_" methods only work if the non-get > version was called first, because they rely on a cached value! This is > really bad, because it forces the end user to understand how the caching > works. This should just be transparent. > > Also, I want to add a quarter_of_financial_year method. > > > -dave > > /*======================= > House Absolute Consulting > www.houseabsolute.com > =======================*/ >
