On Thu, 10 Jun 2004, Dave Rolsky wrote: > Well, Rich Bowen had started working on the same module, so you should > talk to him. Reviewing the code/docs, I have a couple nits: >
Oh yeah I just saw that in the list archives. > - The constructor shouldn't take rd_secs, rd_nanosecs, or locale, I don't > think. The only way to set this should be via the from_object method. > Ok. I'll change that. > - I'm assuming that the "holyday" spelling is intentional, right? > Yes. That seems to be the way Discordian texts spell it. > - days_till_x should be days_until_x. I'm not a big fan of abbreviations > in general, unless they're ridiculously obvious, and "till" is the wrong > abbreviation anyway ;) > Ok. I'll change that. > - You have %% documented twice. > > - Using ü in the exclamations probably isn't right. This is part of > Latin-1, so use that character. > I think both of these are artifacts from cutting and pasting from PerlMonks but I'll make sure they are fixed. Apart from being an enjoyable little waste of time, this module is just a warmup for the Hindu calendars I said I was going to do a long time ago. -- Jaldhar H. Vyas <[EMAIL PROTECTED]>
