--- Kevin Hilman <[EMAIL PROTECTED]> wrote: > > I've reverted this patch for a couple reasons: > > 1) It broke the ability to handle zero-length transfers, which are > used > in the smbus probing code.
It would be interesting to know that, which device actully didn't worked with my code. As DaVinci I2C controller looks similar to OMAP I2C controller and so does the code, as it is not good to lie other code about controller capabilities. Because of that I have removed extra zero byte transactions handling code and removing SMBUS_QUICK from it. Please refer following discussion on lkml about OMAP I2C driver. http://lkml.org/lkml/2006/8/2/138 and the latest OMAP I2C driver in Linus mainline tree, as most of other cosmetic changes are coming from there. Also, let me know if some particular chip fails because of removing zero-byte transactions, as similar case can happen for OMAP. > > 2) I haven't heard from you how you are validiating the non-cosmetic > changes. I'm going to need a little higher level of confidence that > the changes actually work to incorporate changes. > For DaVinci EVM, it was able to execute code in i2c-emac.c for getting mac address. I will not have access to DaVinci EVM again for few months, as I am now in Europe. ---Komal Shah http://komalshah.blogspot.com/ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
