Hi Dirk,
Thank you for contributing!
- It does the above stuff (1 & 2) and therefore makes your patch more
generic. Have a look to board/davinci/nand.c part of patch in
attachment. There, it introduces an additional #define
ENABLE_DAVINCI_NAND_HW_ECC which can be used to switch between
NAND_ECC_SOFT and NAND_ECC_HW3IN4_512 by setting this macro in this file.
Yeah, this is nice. You can also ifdef struct nand_oobinfo stuff. And
please rename ENABLE_DAVINCI_NAND_HW_ECC to something like
ENABLE_DAVINCI_NAND_HW_ECC3IN4 (or better CONFIG_...), because this ECC
is a non-standard one (3 bytes, packed in 4 bytes per 512 bytes of
data). And this HW_ ECC3IN4 is incompatible with linux's NAND driver HW_ECC.
- I didn't touch (3), EMIF timing.
Maybe we can add EMIF timing as a CFG option in the
include/configs/davinci.h file.
- I removed tons of trailing whitespaces. Your formatting isn't the
best one ;)
Yes, I know. I used legacy TI code & cut-paste code from the linux NAND
driver so code indentation is a little messy. I see that you converted
whitespace to tabs, which is in conformance with u-boot coding style.
I'm not happy with tab indentation, but I guess this is the right thing
to do if we want to get mainstream.
- I removed the disabling of lib_arm stuff, see below.
Thanks. And thanks for the _udivsi3 patch!
- Patch cleanly applies to recent uboot git.
Great! I have several other drivers that I would like to share, but one
of them use TI proprietary code and I haven't spoken with TI people
about it yet.
Here's the complete list:
EPCS (serial flash device used by Altera FPGAs)
EFSL (this is a *writable* FAT filesystem)
GPIO driver
SD Card driver
LCD (with a TI logo and color progress bar)
+#
==========================================================================
+# MultiMedia Solutions Ltd.
+# (c) Copyright 2007, MultiMedia Solutions Ltd. All Rights Reserved.
+#
+# Use of this software is controlled by the terms and conditions
found
+# in the license agreement under which this software has been
supplied.
+#
==========================================================================
Mmmh? This is no GPL?
My bad. I forgot to wipe the header out :) Assume the license being "GPL"
BR,
Ivan
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
