Bernard Blackham wrote:
This is actually a forward port of the SD/MMC driver from the latest
LSP, melded into linux-2.6.23-git. I've tried to keep the style
updates that were merged recently. I fixed the exit code (in
davinci_mmcsd_exit) to release clocks, and some failure paths in
davinci_mmcsd_init.
This is probably not quite what David and Dirk were wanting, as it's
probably further from being merged upstream than previously.
However, it works for me (have tried reading/writing an SD card
successfully, reading at about ~6MB/s and writing at ~1MB/s). It
hasn't been put under particularly strenuous testing either, so
beware.
Many thanks!
I had a quick look to it. It applies and compiles cleany. And if it
works for you, maybe it works for others as well ;)
This is a big improvement against the driver currently in git, so IMHO
we should apply it.
--- a/drivers/mmc/host/davinci_mmc.h
+++ b/drivers/mmc/host/davinci_mmc.h
@@ -132,6 +132,7 @@ #define DAVINCI_MMC_DATADIR_WRITE 2
int power_pin;
int use_dma;
+ int do_dma;
struct completion dma_completion;
Only one thing that confused me: Additionally to use_dma there is now
do_dma. At some places in the patch use_dma is replaced by do_dma. But
at some places use_dma is still used and do_dma is used additionally.
What's the difference between use_dma and do_dma? Sorry, I'm no
MMC/DMA expert.
Cheers
Dirk
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
