steven.zhang wrote:
This patch mainly ports the video resizer driver by TI to Davinci 6446
on kernel 2.6.23.
"ti_davinci_mv_1_0_video_resizer_driver_009" is the original driver
supported by TI.
See comments below.
"video-resizer-port.patch" is the patch ported by Neuros.
See comments below.
ti_davinci_mv_1_0_video_resizer_driver_009:
Index: linux-2.6.10_mvl401/drivers/char/Kconfig
===================================================================
--- linux-2.6.10_mvl401.orig/drivers/char/Kconfig
+++ linux-2.6.10_mvl401/drivers/char/Kconfig
...
@@ -1040,8 +1040,8 @@ config XILINX_SPI
config RAW_DRIVER
tristate "RAW driver (/dev/raw/rawN) (OBSOLETE)"
help
- The raw driver permits block devices to be bound to /dev/raw/rawN.
- Once bound, I/O against /dev/raw/rawN uses efficient zero-copy I/O.
+ The raw driver permits block devices to be bound to /dev/raw/rawN.
+ Once bound, I/O against /dev/raw/rawN uses efficient zero-copy I/O.
See the raw(8) manpage for more details.
The raw driver is deprecated and may be removed from 2.7
...
With this I get a reject on clean git checkout pre-2.6.24-merge.
Anything with tab/space? I can't see the difference in these lines ;)
The other changes in Kconfig apply fine, though.
Index: linux-2.6.10_mvl401/drivers/char/Makefile
===================================================================
--- linux-2.6.10_mvl401.orig/drivers/char/Makefile
+++ linux-2.6.10_mvl401/drivers/char/Makefile
@@ -102,6 +102,9 @@ obj-$(CONFIG_DRM) += drm/
obj-$(CONFIG_PCMCIA) += pcmcia/
obj-$(CONFIG_IPMI_HANDLER) += ipmi/
+davinci_rsz_driver-objs := davinci_resizer_hw.o davinci_resizer.o
+obj-$(CONFIG_RESIZER) += davinci_rsz_driver.o
+
obj-$(CONFIG_HANGCHECK_TIMER) += hangcheck-timer.o
obj-$(CONFIG_DAVINCI_RTC) += davinci-rtc.o
...
Rejected as well on clean pre-2.6.24-merge. Can't see an obvious
reason, tab/space?
The rest of ti_davinci_mv_1_0_video_resizer_driver_009 applies cleanly
then.
Unfortunately,
./scripts/checkpatch.pl ti_davinci_mv_1_0_video_resizer_driver_009
is quite unhappy.
video-resizer-port.patch:
diff --git a/linux-2.6.23/drivers/char/davinci_resizer.c
b/linux-2.6.23/drivers/char/davinci_resizer.c
index a1197f3..07463ca 100644
--- a/linux-2.6.23/drivers/char/davinci_resizer.c
+++ b/linux-2.6.23/drivers/char/davinci_resizer.c
You did this patch on an other directory level as
ti_davinci_mv_1_0_video_resizer_driver_009 above. I had to change the
-p option of patch or remove the "a/" and "b/" from the patch to be
able to use same -p level as for
ti_davinci_mv_1_0_video_resizer_driver_009.
Doing this, video-resizer-port.patch applies cleanly on top of
ti_davinci_mv_1_0_video_resizer_driver_009.
- dev_dbg(rsz_device, "Channel in use", ret);
+ //dev_dbg(rsz_device, "Channel in use", ret);
Remove this if you don't need it. And don't use //.
@@ -1496,19 +1501,12 @@ static int resizer_remove(struct device *device)
{
return 0;
}
-static struct class_simple *rsz_class = NULL;
-
-static struct platform_device resizer_device = {
- .name = "davinci_resizer",.id = 2,.dev = {
- .release =
- resizer_platform_release,}
-};
+static struct class *rsz_class = NULL;
do not initialise statics to 0 or NULL
+ if (misc_register(&resizer_device))
+ {
That open brace { should be on the previous line
(all results from checkpatch)
I propose to clean up the patches, rename them to 01_xxx and 02_xxx
and then send them again as [PATCH 1/2] .. and [PATCH 2/2]. And don't
forget your Signed-off-by ;)
Regards
Dirk
Btw.: If I fix above rejects, both patches apply to recent 2.6.24 git
as well :)
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
