On Wed, 2008-03-26 at 06:25 +0100, Dirk Behme wrote:
> steven.zhang wrote:
> > On Mon, 2008-03-24 at 13:49 +0800, steven.zhang wrote:
> > 
> >>This patch provides the Video Resizer support for DaVinci on kernel
> >>2.6.10.
> >>sign-off-by: [EMAIL PROTECTED]
> >>_______________________________________________
> >>Davinci-linux-open-source mailing list
> >>[email protected]
> >>http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
> >  
> > What about the status of these two patch ? Thanks.
> 
> Do you refer to
> 
> http://linux.omap.com/pipermail/davinci-linux-open-source/2008-March/005828.html
> http://linux.omap.com/pipermail/davinci-linux-open-source/2008-March/005829.html
> 
> ?
> 
> - As already mentioned several times, patches should be checkpatch 
> clean. Seems to me that you introduced additional checkpatch warnings 
> to patch 02. Some older patches were cleaner.
> 
> Patch 01:
> 
> total: 1 errors, 46 warnings, 2238 lines checked
> 
> Patch 02:
> 
> total: 0 errors, 32 warnings, 365 lines checked
> 
> What is the problem to run checkpatch *before* sending the patches to ML?
> 
> - As already mentioned several times, still strip level 2.
> 
> - A minor thing, but the correct string is "Signed-off-by"
> 
> Sorry if I'm missing something.
> 
Dirk, thanks for the patience and understanding of the learning curve
here. :)

Steven, 

Please feel free to ask if you still have any parts uncertain, I for one
don't understand how I can help. All I know is let's upstream the work
we've done here. ;-)

Yes, it is painful (and seems not helping our internal dev to begin
with), but it surely will help us in the long run, for example, you may
not need to up-port this to 2.6.25. And after all, once you learn this,
Neuros learns it. :)

Thanks,

/MG



_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to