steven.zhang wrote:
Video resizer driver supported by TI

Signed-off-by: steven.zhang<[EMAIL PROTECTED]>

Sorry, but:

-- cut --

> ./scripts/checkpatch.pl patches/01-ARM-Davinci-resizer-dirver-supported-by-TI.patch

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#156: FILE: drivers/char/davinci_resizer.c:99:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#296: FILE: drivers/char/davinci_resizer.c:239:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#309: FILE: drivers/char/davinci_resizer.c:252:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#376: FILE: drivers/char/davinci_resizer.c:319:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#408: FILE: drivers/char/davinci_resizer.c:351:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#534: FILE: drivers/char/davinci_resizer.c:477:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#548: FILE: drivers/char/davinci_resizer.c:491:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#602: FILE: drivers/char/davinci_resizer.c:545:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#615: FILE: drivers/char/davinci_resizer.c:558:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#662: FILE: drivers/char/davinci_resizer.c:605:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#677: FILE: drivers/char/davinci_resizer.c:620:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: braces {} are not necessary for any arm of this statement
#724: FILE: drivers/char/davinci_resizer.c:667:
+               if (params->inptyp == RSZ_INTYPE_PLANAR_8BIT) {
[...]
+               } else if (params->inptyp == RSZ_INTYPE_YCBCR422_16BIT) {
[...]
+               } else {
[...]

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#964: FILE: drivers/char/davinci_resizer.c:907:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#979: FILE: drivers/char/davinci_resizer.c:922:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1098: FILE: drivers/char/davinci_resizer.c:1041:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1106: FILE: drivers/char/davinci_resizer.c:1049:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1119: FILE: drivers/char/davinci_resizer.c:1062:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");;

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1130: FILE: drivers/char/davinci_resizer.c:1073:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1154: FILE: drivers/char/davinci_resizer.c:1097:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1168: FILE: drivers/char/davinci_resizer.c:1111:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: consider using a completion
#1231: FILE: drivers/char/davinci_resizer.c:1174:
+       init_MUTEX_LOCKED(&(rsz_conf_chan->channel_sem));

WARNING: mutexes are preferred for single holder semaphores
#1233: FILE: drivers/char/davinci_resizer.c:1176:
+       init_MUTEX(&(rsz_conf_chan->chanprotection_sem));

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1237: FILE: drivers/char/davinci_resizer.c:1180:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1257: FILE: drivers/char/davinci_resizer.c:1200:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1277: FILE: drivers/char/davinci_resizer.c:1220:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");;

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1306: FILE: drivers/char/davinci_resizer.c:1249:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1355: FILE: drivers/char/davinci_resizer.c:1298:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1382: FILE: drivers/char/davinci_resizer.c:1325:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1524: FILE: drivers/char/davinci_resizer.c:1467:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1542: FILE: drivers/char/davinci_resizer.c:1485:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1547: FILE: drivers/char/davinci_resizer.c:1490:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: mutexes are preferred for single holder semaphores
#1664: FILE: drivers/char/davinci_resizer.c:1607:
+       init_MUTEX(&device_config.array_sem);

WARNING: mutexes are preferred for single holder semaphores
#1665: FILE: drivers/char/davinci_resizer.c:1608:
+       init_MUTEX(&device_config.device_mutex);

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1761: FILE: drivers/char/davinci_resizer_hw.c:39:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1832: FILE: drivers/char/davinci_resizer_hw.c:110:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1843: FILE: drivers/char/davinci_resizer_hw.c:121:
+       dev_dbg(rsz_device, __FUNCTION__ "E\n");

WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#1855: FILE: drivers/char/davinci_resizer_hw.c:133:
+       dev_dbg(rsz_device, __FUNCTION__ "L\n");

total: 0 errors, 37 warnings, 2248 lines checked

patches/01-ARM-Davinci-resizer-dirver-supported-by-TI.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

-- cut --

Dirk
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to