Hi Kevin,
On Thu, May 8, 2008 at 10:12 PM, Kevin Hilman <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
>>
>> From: Trilok Soni <[EMAIL PROTECTED]>
>>
>> - Addes common.c which implements bootloader tag passing support,
>> as well board config structure passing support from board specific
>> file. e.g for DAVINCI_TAG_UART, to specify enabled uarts pattern,
>> and DAVINCI_TAG_SERIAL_CONSOLE to specify console UART and it's baudrate.
>>
>> - This patch code is mostly derived from the OMAP TAG support code and it
>> is
>> tested on DaVinci DM6446 based custom board.
>>
>> Signed-off-by: Trilok Soni <[EMAIL PROTECTED]>
>
> Hi Trilok,
>
> Can you fix the checkpatch warnings/errors in this patch? Running
> scripts/checkpatch.pl, I get:
>
> total: 4 errors, 1 warnings, 282 lines checked
>
> The DAVINCI_TAG_UART patch looks ok, and I'll apply both after the fixups.
>
Out of this four errors, I am not sure what is the best way to solve
following two errors. Looks like checkpatch bug.
ERROR: need consistent spacing around '*' (ctx:WxB)
#44: FILE: asm-arm/arch-davinci/board.h:44:
+ ((const type *) __davinci_get_config((tag), sizeof(type), 0))
^
ERROR: need consistent spacing around '*' (ctx:WxB)
#46: FILE: asm-arm/arch-davinci/board.h:46:
+ ((const type *) __davinci_get_config((tag), sizeof(type), (nr)))
^
total: 2 errors, 0 warnings, 53 lines checked
include/asm-arm/arch-davinci/board.h has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
You can see that, it is expecting space after '*', but if we add one
space after '*' then it will prompt another error saying that "space
before closing parenthesis ')'" is not allowed :).
If you are OK with above errors, I can send you the updated patch.
--
---Trilok Soni
http://triloksoni.wordpress.com
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
