Hi Anant, On Wed, May 14, 2008 at 9:03 PM, Anant Gole <[EMAIL PROTECTED]> wrote: >>---------- Forwarded message ---------- >>From: [EMAIL PROTECTED] >>To: [email protected] >>Date: Wed, 14 May 2008 11:44:15 +0530 >>Subject: [PATCH] NET: DaVinci: EMAC driver platform driver model conversion >>and misc. cleanups. >>From: Trilok Soni <[EMAIL PROTECTED]> >> >>- Convert EMAC driver to use platform driver model. >>- Start doing scripts/checkpatch.pl conversions. Not all reported errors >> by this tool are handled right now. Following are major one: >> - Remove use of typedefs. >> - Use dev_dbg/err whenever see fit. I will remove DBG related >> macros with better debugging level wherever necessary. >> - Remove kcalloc and kfree wrappers. Use kzalloc/kfree directly. >> Rest of checkpatch.pl errors, which are not handled right now are mostly >> falls into 80 chars line limit, usage spaces instead of tabs, KERN_* >> facility etc. cosmetic stuff, which will be handled in second phase of >> cleanups. >> >> Driver is tested with NFS mounting on DM644x custom board. > > Trilok, > > I should have announced this earlier, but I am working on recoding > this driver to truely get it into linux fold as this driver was "linuxified" > some time back (thanks to Kevin for the efforts) as it was not written > for Linux originally, but we decided not to touch it too much with the > fear of breaking its functionality. > > Right now I am of the opinion that it just needs a clean revamp in data > structures and the code in general as there is a lot of unused code in > there and featuers that need to be removed apart from running > checkpatch and moving it to latest netdev changes > .
Please share your changes, and I can probably merge on top of my changes. -- ---Trilok Soni http://triloksoni.wordpress.com _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
