"Gole, Anant" <[EMAIL PROTECTED]> writes: > This patch does the following: > - cleanup of EMAC driver code - followed linux coding guidelines > - removed unused code > - removed register access, using davinci register access macros > > This is a large patch but I preferred to cleanup the whole driver > rather than bits and pieces of it. Attached a compressed > patch as I could not send it inline or as plain attachment due > to size limitations on this mailing list. > > Signed-off-by: Anant Gole <[EMAIL PROTECTED]>
Thanks, pushing today. One other minor thing for the next round of cleanups... Most of the comments for the fields in the various structs are redundant. IOW, the struct field name is as descriptive as the comment. I think you can get rid of most of the comments there as they don't add much value. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
