Jaswinder Singh wrote:
Can we please create new files for the DM355 and DM6467?
I don't mind hardware.h including all
i.e.
#include "hardware355.h"
#include "hardware6467.h"
I will suggest hardware.h should only have common stuff and it will
call files as per CONFIG by this way we make it clean and more modular
:-
asm/arch/hardware.h:
#ifdef CONFIG_ARCH_DAVINCI_DM644x
#include <asm/arch/hardware_644x.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM646x
#include <asm/arch/hardware_646x.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM355
#include <asm/arch/hardware_355.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM335
#include <asm/arch/hardware_335.h>
#endif
And if you want to share common stuff you can further divide like this :
asm/arch/hardware.h :
#ifdef CONFIG_ARCH_DAVINCI_DM64xx
#include <asm/arch/hardware_64xx.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM3xx
#include <asm/arch/hardware_3xx.h>
#endif
asm/arch/hardware_64xx.h:
#ifdef CONFIG_ARCH_DAVINCI_DM644x
#include <asm/arch/hardware_644x.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM646x
#include <asm/arch/hardware_646x.h>
#endif
asm/arch/hardware_3xx.h:
#ifdef CONFIG_ARCH_DAVINCI_DM355
#include <asm/arch/hardware_355.h>
#endif
#ifdef CONFIG_ARCH_DAVINCI_DM335
#include <asm/arch/hardware_335.h>
#endif
Thank you,
Jaswinder Singh.
That does look nice. But I'm fine with just a separate file
if that's all they want to do.
Troy
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
